samples: openthread: align nRF_Connect_SDK_13_14.py with GRLv64 #25848

jaul-nsc · 2025-11-27T09:50:54Z

Align the nRF_Connect_SDK_13_14.py THCI file with the GRL Thread's certification framework in version 64.0

Copilot

Pull request overview

This PR aligns the nRF_Connect_SDK_13_14.py THCI (Thread Host Controller Interface) file with GRL Thread's certification framework version 64.0. The changes primarily involve updating API methods, fixing parameter ordering, and adding new functionality to support the latest certification requirements.

Key changes:

Added new API methods for ICMP ping, SRP service registration, TCP HTTP requests, and NAT64 prefix handling
Fixed parameter ordering in SRP-related methods (swapping priority and weight parameters)
Enhanced UDP and DNS query methods with additional options and parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-27T09:52:35Z

samples/openthread/cli/harness-thci/nRF_Connect_SDK_13_14.py

@@ -3736,7 +3765,9 @@ def get_own_omr_address(self, omr_prefix):

    def srp_client_remove(self, instancename, servicename):
        cmd = "srp client service remove %s %s" % (instancename, servicename)
+        # cmd = 'srp client service remove service-test-1 _thread-test._udp'


Remove commented-out code. If this is an example, consider adding it to documentation instead.

Suggested change

# cmd = 'srp client service remove service-test-1 _thread-test._udp'

Copilot · 2025-11-27T09:52:36Z

samples/openthread/cli/harness-thci/nRF_Connect_SDK_13_14.py

        self.__executeCommand(cmd)
+        # self.__executeCommand("netdata register")


Remove commented-out code. If this command should be executed conditionally, implement proper conditional logic instead.

Suggested change

# self.__executeCommand("netdata register")

Copilot · 2025-11-27T09:52:36Z

samples/openthread/cli/harness-thci/nRF_Connect_SDK_13_14.py

-        self.__executeCommand(cmd)
+        if ip_addr:
+            cmd += f" {ip_addr} 53 6000 3 1"
+        print(cmd)


Replace print statement with proper logging using self.log() as used elsewhere in the file.

Copilot · 2025-11-27T09:52:36Z

samples/openthread/cli/harness-thci/nRF_Connect_SDK_13_14.py

+        tcp_request = self.__executeCommand(
+            "tcp send -x %s" % hexa_http_request, ignore_exec=True
+        )
+        print(tcp_request)


Replace print statement with proper logging using self.log() as used elsewhere in the file.

Suggested change

print(tcp_request)

self.log(tcp_request)

Copilot · 2025-11-27T09:52:37Z

samples/openthread/cli/harness-thci/nRF_Connect_SDK_13_14.py

+        time.sleep(3)
+        self.__executeCommand("tcp sendend", ignore_exec=True)
+        self.__executeCommand("tcp deinit", ignore_exec=True)
+        return "Failed" if tcp_request is True else True


The logic is inverted and confusing. When tcp_request is True (success with ignore_exec), it returns 'Failed' string. When it's not True, it returns True boolean. This should return consistent boolean values: return tcp_request is not True.

Suggested change

return "Failed" if tcp_request is True else True

return tcp_request is not True

Copilot · 2025-11-27T09:52:37Z

samples/openthread/cli/harness-thci/nRF_Connect_SDK_13_14.py

+            else:
+                continue


The else-continue is unnecessary. Remove the else clause since continue is only needed when the condition is false.

Suggested change

else:

continue

continue

NordicBuilder · 2025-11-27T09:58:07Z

CI Information

^{To view the history of this post, click the 'edited' button above}
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 9fa68304ce5e3b36879db9770b43adfb3f36757a

more details

sdk-nrf:

PR head: 9fa68304ce5e3b36879db9770b43adfb3f36757a
merge base: 78f8c43b230ef210d5882b222ee8e0b5960cb904
target head (main): 0c79406a493836eff01af3bf4a75b49a5a47ca16
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (1)

samples
│  ├── openthread
│  │  ├── cli
│  │  │  ├── harness-thci
│  │  │  │  │ nRF_Connect_SDK_13_14.py

Outputs:

Toolchain

Version: 964ddb2c70
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:964ddb2c70_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 53
✅ Integration tests
- ✅ test-fw-nrfconnect-thread-main

Disabled integration tests

- test-fw-nrfconnect-nrf_lrcs_positioning
- desktop52_verification
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps-main
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

ArekBalysNordic

ADNO

Align the nRF_Connect_SDK_13_14.py THCI file with the GRL Thread's certification framework in version 64.0. Signed-off-by: Jakub Uliarczyk <[email protected]>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

samples/openthread/cli/harness-thci/nRF_Connect_SDK_13_14.py

Copilot AI review requested due to automatic review settings November 27, 2025 09:50

jaul-nsc requested review from a team as code owners November 27, 2025 09:50

NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 27, 2025

Copilot AI reviewed Nov 27, 2025

View reviewed changes

ArekBalysNordic approved these changes Nov 27, 2025

View reviewed changes

jaul-nsc added this to the 3.2.0 milestone Nov 27, 2025

jaul-nsc force-pushed the feature/align-thci-to-grl-v64 branch 3 times, most recently from e465849 to b9225ae Compare November 27, 2025 10:47

rlubos approved these changes Nov 27, 2025

View reviewed changes

samples: openthread: align THCI with GRLv64

9fa6830

Align the nRF_Connect_SDK_13_14.py THCI file with the GRL Thread's certification framework in version 64.0. Signed-off-by: Jakub Uliarczyk <[email protected]>

Copilot AI review requested due to automatic review settings November 27, 2025 13:35

jaul-nsc force-pushed the feature/align-thci-to-grl-v64 branch from b9225ae to 9fa6830 Compare November 27, 2025 13:35

Copilot AI reviewed Nov 27, 2025

View reviewed changes

		self.__executeCommand(cmd)
		# self.__executeCommand("netdata register")

	return "Failed" if tcp_request is True else True
	return tcp_request is not True

samples: openthread: align nRF_Connect_SDK_13_14.py with GRLv64 #25848

Are you sure you want to change the base?

samples: openthread: align nRF_Connect_SDK_13_14.py with GRLv64 #25848

Uh oh!

Conversation

jaul-nsc commented Nov 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

NordicBuilder commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

ArekBalysNordic left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NordicBuilder commented Nov 27, 2025 •

edited

Loading